Skip to content

✅ Add tests for msg handlers calling multiple callbacks #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

✅ Add tests for msg handlers calling multiple callbacks #712

merged 1 commit into from
Mar 21, 2025

Conversation

@elbeno
Copy link
Contributor

@elbeno elbeno commented Mar 21, 2025

Problem:

  • When multiple callbacks match a message, they should all be called. There was no test binding this behaviour for either the "normal" handler or the indexed handler.

Solution:

  • Add tests that bind the behaviour.

@elbeno
✅ Add tests for msg handlers calling multiple callbacks
b2266ad 
Problem:
- When multiple callbacks match a message, they should all be called. There was
  no test binding this behaviour for either the "normal" handler or the indexed
  handler.

Solution:
- Add tests that bind the behaviour.
@elbeno elbeno enabled auto-merge March 21, 2025 15:07
@elbeno elbeno merged commit f1df5ef into intel:main Mar 21, 2025
24 checks passed
@elbeno elbeno deleted the multi-callback-test branch October 16, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjcaisse-intel mjcaisse-intel mjcaisse-intel approved these changes

@lukevalenty lukevalenty Awaiting requested review from lukevalenty

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elbeno @mjcaisse-intel